<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23421">View Revision</a></tr></table><br /><div><div><p>Works great. I have some UI suggestions below:</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23421#inline-132712">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pageview.cpp:4371</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">squeezedText</span> <span style="color: #aa2211">=</span> <span class="n">KStringHandler</span><span style="color: #aa2211">::</span><span class="n">rsqueeze</span><span class="p">(</span> <span class="n">searchText</span><span class="p">,</span> <span style="color: #601200">21</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="n">webShortcutsMenu</span><span style="color: #aa2211">-></span><span class="n">setTitle</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"Search for '%1' <span class="bright">with</span>"</span><span class="p">,</span> <span class="n">squeezedText</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">webShortcutsMenu</span><span style="color: #aa2211">-></span><span class="n">setTitle</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"Search for '%1' <span class="bright">in</span>"</span><span class="p">,</span> <span class="n">squeezedText</span> <span class="p">)</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This grammar change makes it wrong for all the other entries.</p>

<p style="padding: 0; margin: 8px;">Maybe the new "Search for <text> in open document" menu item should be in the base level of the context menu, and not inside the sub-menu.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23421#inline-132711">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pageview.cpp:4374</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="n">QAction</span> <span style="color: #aa2211">*</span><span class="n">action</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">n<span class="bright">ullptr</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">QAction</span> <span style="color: #aa2211">*</span><span class="n">action</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">n<span class="bright">ew</span></span><span class="bright"> </span><span class="n"><span class="bright">QAction</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Opened Document"</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">webShortcutsMenu</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">action</span><span style="color: #aa2211">-></span><span class="n">setIcon</span><span class="p">(</span> <span class="n">QIcon</span><span style="color: #aa2211">::</span><span class="n">fromTheme</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"document-open"</span><span class="p">)</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">connect</span><span class="p">(</span><span class="n">action</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QAction</span><span style="color: #aa2211">::</span><span class="n">triggered</span><span class="p">,</span> <span class="p">[</span><span class="n">searchText</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">]()</span> <span class="p">{</span> <span class="n">Q_EMIT</span> <span style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span class="n">triggerSearch</span><span class="p">(</span><span class="n">searchText</span><span class="p">);});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The icon should be <tt style="background: #ebebeb; font-size: 13px;">document-preview</tt> (<tt style="background: #ebebeb; font-size: 13px;">document-open</tt> is used for actions that open documents)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R223 Okular</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23421">https://phabricator.kde.org/D23421</a></div></div><br /><div><strong>To: </strong>andisa, Okular<br /><strong>Cc: </strong>ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid<br /></div>