D23421: Add "find in this document" to selection context menu

[Andi Sardina Ramos]

andisa removed a reviewer: Okular.
andisa added inline comments.

INLINE COMMENTS

> ngraham wrote in pageview.cpp:4371
> This grammar change makes it wrong for all the other entries.
> 
> Maybe the new "Search for <text> in open document" menu item should be in the base level of the context menu, and not inside the sub-menu.

I was thinking about that because even if you don't have any external provider, you should have the option to search within the document. I didn't want to change to much the existing code, my fault.

I will update taking into consideration your suggestion.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23421

To: andisa, #okular
Cc: ngraham, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190827/349d5c23/attachment-0001.html>