D10073: [PATCH 1/4] Add JavaScript Event Object handling

[Andre Heinecke]

aheinecke added inline comments.

INLINE COMMENTS

> aacid wrote in kjs_field.cpp:217
> Why the new if?

It is not assured in kjs_event.cpp eventGetSource and eventGetTarget that the targetPage / sourcePage is not null. This depends a how the event object is set up.

Although I think that sourcePage "should" be set when source is set and targetPage should be set if target is set there is no guarantee for this and so I think a check here is warranted.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10073

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180220/33242493/attachment.html>