D10073: [PATCH 1/4] Add JavaScript Event Object handling

Albert Astals Cid noreply at phabricator.kde.org
Mon Feb 19 23:40:09 UTC 2018


aacid added inline comments.

INLINE COMMENTS

> kjs_field.cpp:217
>      KJSObject f = g_fieldProto->constructObject( ctx, field );
> -    f.setProperty( ctx, QStringLiteral("page"), page->number() );
> -    g_fieldCache->insert( field, page );
> +    if (page)
> +    {

Why the new if?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10073

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180219/83ab7058/attachment-0001.html>


More information about the Okular-devel mailing list