D10073: [PATCH 1/4] Add JavaScript Event Object handling

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> aheinecke wrote in kjs_field.cpp:217
> It is not assured in kjs_event.cpp eventGetSource and eventGetTarget that the targetPage / sourcePage is not null. This depends a how the event object is set up.
> 
> Although I think that sourcePage "should" be set when source is set and targetPage should be set if target is set there is no guarantee for this and so I think a check here is warranted.

No, no check is warranted, if page is null is because the code is wrong and it should crash so we can fix it not silently do nothing.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10073

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180220/f81d3b84/attachment.html>