D7714: Show dialog to ask when closing when more than tab open

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D7714#144296, @rkflx wrote:
  
  > > What part of "Are you sure you want to quit" Yes/No you find ambiguous?
  >
  > KDE's HIG says
  >
  >   Label command buttons with an imperative verb.
  >   
  >
  > and also
  >
  >   Use descriptive button labels instead of standard Yes/No or OK/Cancel buttons. For example, if the user must choose to continue or stop an action, provide the buttons "Continue" and "Cancel".
  >   
  >
  > and IIRC there was even a time when a lot of KDE dialogs were converted from Yes/No style to a more action oriented style.
  
  
  So how would you name them, since you're the one blocking on wording, you may as well suggest those names ;)
  
  > 
  > 
  >> This has nothing to do with "this window", it's about the application itself being closed.
  > 
  > Try opening multiple Okular windows with tabs and quit. Only one window (from the perspective of the user) will be closed.
  
  Ok, since you're better at the wording, please suggest a full wording for the dialog.
  
  > 
  > 
  >> Why is warning better?
  > 
  > The "i" in the icon stands for "information", but in reality you are asking the user to pick between two buttons (the "warning" icons signals "attention, decide between two things!" with the imperative literally depicted by "!") Of course, a question mark would also work (maybe even better).
  
  I still disagree with Warning, I'll change it to Question once you give me the correct wordings for the other items.
  
  > 
  > 
  >> That's why firefox wording that i copied is much better
  > 
  > Fair enough. It would be a nice touch if you could also change it in Dolphin then, though.
  
  I'm not going to fix Dolphin *right now*. I may create a new feature for KMessageDialog that allows for people to use different wording instead of "Don't ask me again", and maybe then port Dolphin to it, but that's separate from this feature.
  
  > 
  > 
  >> that doesn't have anything to do with this, we have multiple "don't ask me again" already, so this can't be a blocker.
  > 
  > I thought it was a relevant question, so I brought it up. I'm sorry you feel attacked.
  
  What part of "you can't block this feature on an already existing problem" you think means i feel attacked?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7714

To: aacid
Cc: colomar, rkflx, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170912/4c1c34f2/attachment-0001.html>