[Okular-devel] [okular] [Bug 352876] [PATCH] Presentation: correct durations for "Fade" transition effect by doing 20 FPS instead of 100 frames total

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=352876

Albert Astals Cid <aacid at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |http://commits.kde.org/okul
                   |                            |ar/9f0ff21a22cd6618034e42f7
                   |                            |7d7796169a9db606
         Resolution|---                         |FIXED

--- Comment #4 from Albert Astals Cid <aacid at kde.org> ---
Git commit 9f0ff21a22cd6618034e42f77d7796169a9db606 by Albert Astals Cid, on
behalf of Arseniy Lartsev.
Committed on 14/10/2015 at 22:11.
Pushed by aacid into branch 'master'.

Presentation: correct durations for "Fade" transition effect by doing 20 FPS
instead of 100 frames total

Right now, fade transition is always done in 100 frames. If the intended
duration is, say, 1 second, the actual duration can easily be a few seconds
instead, due to the limited CPU power (on my laptop with core i5, those 100
frames take 2 seconds).

I propose a patch that changes the number of frames to 20 * (duration in
seconds). 20 FPS still looks completely smooth to me.

REVIEW: 125310

M  +4    -2    ui/presentationwidget.cpp
M  +1    -0    ui/presentationwidget.h

http://commits.kde.org/okular/9f0ff21a22cd6618034e42f77d7796169a9db606

-- 
You are receiving this mail because:
You are the assignee for the bug.