[Okular-devel] Review Request 125310: Presentation: correct durations for "Fade" transition effect by doing 20 FPS instead of 100 frames total

[Arseniy Lartsev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125310/
-----------------------------------------------------------

(Updated Oct. 14, 2015, 10:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Changes
-------

Submitted with commit 9f0ff21a22cd6618034e42f77d7796169a9db606 by Albert Astals Cid on behalf of Arseniy Lartsev to branch master.


Bugs: 352876
    http://bugs.kde.org/show_bug.cgi?id=352876


Repository: okular


Description
-------

Right now, fade transition is always done in 100 frames. If the intended duration is, say, 1 second, the actual duration can easily be a few seconds instead, due to the limited CPU power (on my laptop with core i5, those 100 frames take 2 seconds).

I propose a patch that changes the number of frames to 20 * (duration in seconds). 20 FPS still looks completely smooth to me.


Diffs
-----

  ui/presentationwidget.h 81beb6c 
  ui/presentationwidget.cpp 0d9a55d 

Diff: https://git.reviewboard.kde.org/r/125310/diff/


Testing
-------

Works for me.


Thanks,

Arseniy Lartsev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151014/185e0af6/attachment.html>