[Okular-devel] Review Request 125329: Support for non-integer transition durations in PDF presentations

[Arseniy Lartsev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125329/
-----------------------------------------------------------

(Updated Oct. 14, 2015, 10:17 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Changes
-------

Submitted with commit 76c1e944a8a0bb44e63962be9e091baf2191597d by Albert Astals Cid on behalf of Arseniy Lartsev to branch master.


Repository: okular


Description
-------

This patch makes okular's presentation mode correctly handle PDFs that contain non-integer durations for transition effects.

Importantly, transitions less than one second long become, in principle, possible. That might still not work with some effects due to performance issues, but with #125310, the fade transition (which is, arguably, by far the most important one) should be fine.


Diffs
-----

  cmake/modules/FindPoppler.cmake 6389a62 
  core/pagetransition.h 4b6e7f9 
  core/pagetransition.cpp d57106d 
  generators/poppler/config-okular-poppler.h.cmake 1e8ff9e 
  generators/poppler/generator_pdf.cpp b260da3 

Diff: https://git.reviewboard.kde.org/r/125329/diff/


Testing
-------

Works for me with both older and newest poppler


File Attachments
----------------

Test case (2 slides, 0.3 s long fade transition)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/27/3a377ec7-2ecf-4e50-90de-05247af1f6c9__short_transition.pdf


Thanks,

Arseniy Lartsev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151014/1f02474f/attachment.html>