[Okular-devel] Review Request 124651: Implement reading mode functionality.

[Anton Ermolenko]

> On Авг. 26, 2015, 1:46 д.п., Albert Astals Cid wrote:
> > enable reading mode, close okular, open okular, why are some things not as you left them but some are? It should either be totally in read mode or totally not in read mode (i.e ignoring the changes read mode did).
> > 
> > Why is this even a checkable action? If you do Ctrl+Shift+R and then Ctrl+M you recover the menu bar and the "reading mode is still enabled" but it really isn't because the menubar is shown.

Fixed the issue, when reading mode not stored after quitting from okular.

A point for menu item is that you can observe available functions and hotkeys, withouth going through handbook.
A point for not-disabling reading mode, after menu was shown is that there are still sidebar and toolbar to show back, also fullscreen mode operates just like that.


- Anton


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124651/#review84375
-----------------------------------------------------------


On Авг. 30, 2015, 5:40 п.п., Anton Ermolenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124651/
> -----------------------------------------------------------
> 
> (Updated Авг. 30, 2015, 5:40 п.п.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 325190
>     http://bugs.kde.org/show_bug.cgi?id=325190
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Adds functionality to hide all elements with one action.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 90b10b7 
>   conf/okular.kcfg cd9b4df 
>   doc/before-reading-mode.png PRE-CREATION 
>   doc/index.docbook 9cfa303 
>   doc/reading-mode-enabled.png PRE-CREATION 
>   part.h 9eebdb2 
>   part.cpp d461ebe 
>   part.rc 34a1160 
>   ui/readmodemanager.h PRE-CREATION 
>   ui/readmodemanager.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124651/diff/
> 
> 
> Testing
> -------
> 
> Checked if it properly restores elements which was visible before enabling reading mode and do not makes visible elements which wasn't.
> 
> 
> Thanks,
> 
> Anton Ermolenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150830/cbea481c/attachment.html>