<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124651/">https://git.reviewboard.kde.org/r/124651/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Август 26th, 2015, 1:46 д.п. EEST, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">enable reading mode, close okular, open okular, why are some things not as you left them but some are? It should either be totally in read mode or totally not in read mode (i.e ignoring the changes read mode did).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why is this even a checkable action? If you do Ctrl+Shift+R and then Ctrl+M you recover the menu bar and the "reading mode is still enabled" but it really isn't because the menubar is shown.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixed the issue, when reading mode not stored after quitting from okular.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A point for menu item is that you can observe available functions and hotkeys, withouth going through handbook.
A point for not-disabling reading mode, after menu was shown is that there are still sidebar and toolbar to show back, also fullscreen mode operates just like that.</p></pre>
<br />
<p>- Anton</p>
<br />
<p>On Август 30th, 2015, 5:40 п.п. EEST, Anton Ermolenko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular and Albert Astals Cid.</div>
<div>By Anton Ermolenko.</div>
<p style="color: grey;"><i>Updated Авг. 30, 2015, 5:40 п.п.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=325190">325190</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adds functionality to hide all elements with one action.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Checked if it properly restores elements which was visible before enabling reading mode and do not makes visible elements which wasn't.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(90b10b7)</span></li>
<li>conf/okular.kcfg <span style="color: grey">(cd9b4df)</span></li>
<li>doc/before-reading-mode.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/index.docbook <span style="color: grey">(9cfa303)</span></li>
<li>doc/reading-mode-enabled.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>part.h <span style="color: grey">(9eebdb2)</span></li>
<li>part.cpp <span style="color: grey">(d461ebe)</span></li>
<li>part.rc <span style="color: grey">(34a1160)</span></li>
<li>ui/readmodemanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/readmodemanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124651/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>