[Okular-devel] Review Request 124651: Implement reading mode functionality.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124651/#review84375
-----------------------------------------------------------


enable reading mode, close okular, open okular, why are some things not as you left them but some are? It should either be totally in read mode or totally not in read mode (i.e ignoring the changes read mode did).

Why is this even a checkable action? If you do Ctrl+Shift+R and then Ctrl+M you recover the menu bar and the "reading mode is still enabled" but it really isn't because the menubar is shown.


ui/readmodemanager.h (line 30)
<https://git.reviewboard.kde.org/r/124651/#comment58423>

    Why are those two const?


- Albert Astals Cid


On ago. 16, 2015, 2:10 p.m., Anton Ermolenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124651/
> -----------------------------------------------------------
> 
> (Updated ago. 16, 2015, 2:10 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 325190
>     http://bugs.kde.org/show_bug.cgi?id=325190
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Adds functionality to hide all elements with one action.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 27a88dd 
>   doc/before-reading-mode.png PRE-CREATION 
>   doc/index.docbook 1896af3 
>   doc/reading-mode-enabled.png PRE-CREATION 
>   part.h 9eebdb2 
>   part.cpp d461ebe 
>   part.rc 60f86e5 
>   ui/readmodemanager.h PRE-CREATION 
>   ui/readmodemanager.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124651/diff/
> 
> 
> Testing
> -------
> 
> Checked if it properly restores elements which was visible before enabling reading mode and do not makes visible elements which wasn't.
> 
> 
> Thanks,
> 
> Anton Ermolenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150825/524e0deb/attachment.html>