[Okular-devel] Review Request 112135: Fix for Bug 323262 and Bug 323263

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112135/#review40819
-----------------------------------------------------------


Thanks and sorry for the delay in review, was away in holiday

About if using real files or syntetic textpages, if not very hard, i think it'd be cooler to use syntetic textpages, since that way we can add tests for stuff like bugs 311232, 309030, etc.

Do you think you can have a look (no need to add the bugs i mention, but it's probably easier to add more tests in the future if we have the syntetic textpages thing than adding more and more documents to git, which is big enough already)


core/textpage.cpp
<http://git.reviewboard.kde.org/r/112135/#comment30000>

    This is an unrelated fix, right?


- Albert Astals Cid


On Aug. 31, 2013, 6:13 a.m., Jaan Vajakas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112135/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2013, 6:13 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch solves Bug 323262 and Bug 323263. I also refactored and simplified the code a little. By removing unnecessary calls to toLower in TextPagePrivate::findTextInternalForward and TextPagePrivate::findTextInternalBackward I also fixed a small bug: the letter capital I with dot above (U+0130) did not match itself in case-insensitive mode on Qt 4.8.4 (U+0130 still does not match lowercase i (U+0069), which can be considered another bug, that I didn't fix (although this behavior conforms to the Unicode case folding rules)). 
> 
> (I did not implement the Knuth-Morris-Pratt algorithm that I promised in a comment of Bug 323263 because on second thought I find that the win, if any, would probably be negligible except for some very special documents and special query strings.)
> 
> 
> This addresses bugs 323262 and 323263.
>     http://bugs.kde.org/show_bug.cgi?id=323262
>     http://bugs.kde.org/show_bug.cgi?id=323263
> 
> 
> Diffs
> -----
> 
>   core/textpage.cpp 855942d 
>   core/textpage_p.h 8ecf0c9 
>   tests/data/a_ba_b.djvu PRE-CREATION 
>   tests/data/abab.pdf PRE-CREATION 
>   tests/data/abababa.pdf PRE-CREATION 
>   tests/searchtest.cpp 495107d 
> 
> Diff: http://git.reviewboard.kde.org/r/112135/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> tests/data/a_ba_b.djvu
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/a_ba_b.djvu
> tests/data/abab.pdf
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/abab.pdf
> tests/data/abababa.pdf
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/abababa.pdf
> 
> 
> Thanks,
> 
> Jaan Vajakas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130925/1cd3da1a/attachment.html>