<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112135/">http://git.reviewboard.kde.org/r/112135/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks and sorry for the delay in review, was away in holiday
About if using real files or syntetic textpages, if not very hard, i think it'd be cooler to use syntetic textpages, since that way we can add tests for stuff like bugs 311232, 309030, etc.
Do you think you can have a look (no need to add the bugs i mention, but it's probably easier to add more tests in the future if we have the syntetic textpages thing than adding more and more documents to git, which is big enough already)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112135/diff/2/?file=185753#file185753line120" style="color: black; font-weight: bold; text-decoration: underline;">core/textpage.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static bool doesConsumeY(const QRect& first, const QRect& second, int threshold)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">109</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="kt">int</span> <span class="n">percentage</span> <span class="o">=</span> <span class="p">(</span><span class="n">first</span><span class="p">.</span><span class="n"><span class="hl">width</span></span><span class="p">()</span> <span class="o"><</span> <span class="n">second</span><span class="p">.</span><span class="n"><span class="hl">width</span></span><span class="p">())</span> <span class="o">?</span> <span class="n">overlap</span> <span class="o">*</span> <span class="mi">100</span> <span class="o">/</span> <span class="p">(</span><span class="n">first</span><span class="p">.</span><span class="n">bottom</span><span class="p">()</span> <span class="o">-</span> <span class="n">first</span><span class="p">.</span><span class="n">top</span><span class="p">())</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">114</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="kt">int</span> <span class="n">percentage</span> <span class="o">=</span> <span class="p">(</span><span class="n">first</span><span class="p">.</span><span class="n"><span class="hl">height</span></span><span class="p">()</span> <span class="o"><</span> <span class="n">second</span><span class="p">.</span><span class="n"><span class="hl">height</span></span><span class="p">())</span> <span class="o">?</span> <span class="n">overlap</span> <span class="o">*</span> <span class="mi">100</span> <span class="o">/</span> <span class="p">(</span><span class="n">first</span><span class="p">.</span><span class="n">bottom</span><span class="p">()</span> <span class="o">-</span> <span class="n">first</span><span class="p">.</span><span class="n">top</span><span class="p">())</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is an unrelated fix, right?</pre>
</div>
<br />
<p>- Albert</p>
<br />
<p>On August 31st, 2013, 6:13 a.m. UTC, Jaan Vajakas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Jaan Vajakas.</div>
<p style="color: grey;"><i>Updated Aug. 31, 2013, 6:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch solves Bug 323262 and Bug 323263. I also refactored and simplified the code a little. By removing unnecessary calls to toLower in TextPagePrivate::findTextInternalForward and TextPagePrivate::findTextInternalBackward I also fixed a small bug: the letter capital I with dot above (U+0130) did not match itself in case-insensitive mode on Qt 4.8.4 (U+0130 still does not match lowercase i (U+0069), which can be considered another bug, that I didn't fix (although this behavior conforms to the Unicode case folding rules)).
(I did not implement the Knuth-Morris-Pratt algorithm that I promised in a comment of Bug 323263 because on second thought I find that the win, if any, would probably be negligible except for some very special documents and special query strings.)
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=323262">323262</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=323263">323263</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/textpage.cpp <span style="color: grey">(855942d)</span></li>
<li>core/textpage_p.h <span style="color: grey">(8ecf0c9)</span></li>
<li>tests/data/a_ba_b.djvu <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/data/abab.pdf <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/data/abababa.pdf <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/searchtest.cpp <span style="color: grey">(495107d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112135/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/a_ba_b.djvu">tests/data/a_ba_b.djvu</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/abab.pdf">tests/data/abab.pdf</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/abababa.pdf">tests/data/abababa.pdf</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>