[Okular-devel] Review Request 112370: BugFix for bug 323434/323435

[Tingnan Zhang]

> On Sept. 25, 2013, 8:51 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 3580
> > <http://git.reviewboard.kde.org/r/112370/diff/1/?file=185717#file185717line3580>
> >
> >     Sorry for tha late reply, been on holiday.
> >     
> >     Since incFactor and decFactor are only used inside some of the cases can you please move their definition insdei the case? Also make them const, and also we don't need modFactor out.
> >     
> >

I have uploaded the modified version. with the definitions now inside the case. 


- Tingnan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112370/#review40818
-----------------------------------------------------------


On Sept. 27, 2013, 1:21 a.m., Tingnan Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112370/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2013, 1:21 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> BugFix 323434/323435. Zoom factor now will be properly rounded to those "interval values" like 140%, 250%, etc, when using zoom in and out feature. 
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 0d6c567d836340555b3101b58178a9247959543a 
> 
> Diff: http://git.reviewboard.kde.org/r/112370/diff/
> 
> 
> Testing
> -------
> 
> done on local machine
> 
> 
> Thanks,
> 
> Tingnan Zhang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130928/42f55d50/attachment.html>