[Okular-devel] Review Request 109096: Open print dialog from command line

[Tomáš Poledný]

> On Feb. 27, 2013, 10:35 p.m., Albert Astals Cid wrote:
> > part.cpp, line 1322
> > <http://git.reviewboard.kde.org/r/109096/diff/3/?file=115231#file115231line1322>
> >
> >     Why are you using invokeMethod here?

I'm sorry my fault. I was not thinking about it. Calling method is better. I hope that now everything will be okay.


> On Feb. 27, 2013, 10:35 p.m., Albert Astals Cid wrote:
> > shell/main.cpp, line 34
> > <http://git.reviewboard.kde.org/r/109096/diff/3/?file=115232#file115232line34>
> >
> >     Why are those here? Seems to me you are trying to fix multiple things in a same review, this is a bad idea, actually you shouldn't even implement print and noraise in the same review, one review per feature is better, allows smaller and self-contained commits to be done.

Ok I will make 3 different review request. Sorry for that. Lessons learned for next time.


- Tomáš


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109096/#review28230
-----------------------------------------------------------


On Feb. 27, 2013, 11:58 p.m., Tomáš Poledný wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109096/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2013, 11:58 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Added command line options print. Bug 252462
> 
> 
> This addresses bug 252462.
>     http://bugs.kde.org/show_bug.cgi?id=252462
> 
> 
> Diffs
> -----
> 
>   kdocumentviewer.h 2f77610 
>   part.h 2fcdf0a 
>   part.cpp 912716a 
>   shell/main.cpp 226dab8 
>   shell/shell.cpp 81d63c2 
> 
> Diff: http://git.reviewboard.kde.org/r/109096/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomáš Poledný
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130228/11781747/attachment.html>