[Okular-devel] Review Request 109096: Open print dialog from command line
Tomáš Poledný
saljacky at gmail.com
Wed Feb 27 23:56:59 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109096/#review28234
-----------------------------------------------------------
part.cpp
<http://git.reviewboard.kde.org/r/109096/#comment21100>
I'm sorry my fault. I was not thinking about it. Calling method is better. I hope that now everything will be okay.
shell/main.cpp
<http://git.reviewboard.kde.org/r/109096/#comment21099>
Ok I will make 3 different review request. Sorry for that. Lessons learned for next time.
- Tomáš Poledný
On Feb. 24, 2013, 3:01 p.m., Tomáš Poledný wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109096/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2013, 3:01 p.m.)
>
>
> Review request for Okular.
>
>
> Description
> -------
>
> Added command line options print. Bug 252462
>
>
> This addresses bugs 252462 and 315538.
> http://bugs.kde.org/show_bug.cgi?id=252462
> http://bugs.kde.org/show_bug.cgi?id=315538
>
>
> Diffs
> -----
>
> kdocumentviewer.h 2f77610
> part.h e3a9418
> part.cpp f1cdc11
> shell/main.cpp 226dab8
> shell/shell.cpp 81d63c2
>
> Diff: http://git.reviewboard.kde.org/r/109096/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomáš Poledný
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130227/a33399f7/attachment-0001.html>
More information about the Okular-devel
mailing list