[Okular-devel] Review Request 109096: Open print dialog from command line

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109096/#review28230
-----------------------------------------------------------



part.cpp
<http://git.reviewboard.kde.org/r/109096/#comment21097>

    Why are you using invokeMethod here?



shell/main.cpp
<http://git.reviewboard.kde.org/r/109096/#comment21098>

    Why are those here? Seems to me you are trying to fix multiple things in a same review, this is a bad idea, actually you shouldn't even implement print and noraise in the same review, one review per feature is better, allows smaller and self-contained commits to be done.


- Albert Astals Cid


On Feb. 24, 2013, 3:01 p.m., Tomáš Poledný wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109096/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2013, 3:01 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> Added command line options print. Bug 252462
> 
> 
> This addresses bugs 252462 and 315538.
>     http://bugs.kde.org/show_bug.cgi?id=252462
>     http://bugs.kde.org/show_bug.cgi?id=315538
> 
> 
> Diffs
> -----
> 
>   kdocumentviewer.h 2f77610 
>   part.h e3a9418 
>   part.cpp f1cdc11 
>   shell/main.cpp 226dab8 
>   shell/shell.cpp 81d63c2 
> 
> Diff: http://git.reviewboard.kde.org/r/109096/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomáš Poledný
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20130227/0c67a46e/attachment.html>