[Okular-devel] Review Request: Support high precision Wacom input for creating annotations

[Jon Mease]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106816/
-----------------------------------------------------------

(Updated Oct. 15, 2012, 12:31 a.m.)


Review request for Okular.


Changes
-------

1)  Cleaned up patch based on Albert's comments.  
2)  Reworked PageViewAnnotator::routeTabletEvent slightly. Now all tablet events over the annotations toolbar are set to ignore so that the toolbar will receive the corresponding mouse event.  However, the annotation code still handles TabletMove and TabletRelease events in case an annotation has been drawn onto the toolbar itself. 


Description
-------

This patch adds processing of QTabletEvents to the PageView class. Basically a graphics tablet will behave exactly like a mouse except while creating an annotation. When creating an annotation, the higher precision position of the QTabletEvent is used and this results in smoother free-hand annotations (See the attached image for a before and after comparison).  With this patch in place it's possible to create a nice looking signature in an Okular document using a graphics tablet.


Diffs (updated)
-----

  ui/annotationtools.h 7107042 
  ui/annotationtools.cpp 40fa6fe 
  ui/pageview.h c1b36f4 
  ui/pageview.cpp 2ef10a1 
  ui/pageviewannotator.h a2ef90d 
  ui/pageviewannotator.cpp 9754b5e 

Diff: http://git.reviewboard.kde.org/r/106816/diff/


Testing
-------

* The creation of annotations using the wacom pen (smooth freehand annotations)
* The creation of annotations using the mouse (no change)
* The operation of the annotations menu using both the mouse and the wacom pen (pen behaves just like the mouse).


Thanks,

Jon Mease

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121015/f9ea5f7c/attachment.html>