[Okular-devel] Review Request: Support high precision Wacom input for creating annotations

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106816/#review20414
-----------------------------------------------------------


This review has been submitted with commit b395e742fce0b3dd2f5b1b3b3b943ae881e50ad6 by Jon Mease to branch master.

- Commit Hook


On Oct. 15, 2012, 12:31 a.m., Jon Mease wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106816/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2012, 12:31 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch adds processing of QTabletEvents to the PageView class. Basically a graphics tablet will behave exactly like a mouse except while creating an annotation. When creating an annotation, the higher precision position of the QTabletEvent is used and this results in smoother free-hand annotations (See the attached image for a before and after comparison).  With this patch in place it's possible to create a nice looking signature in an Okular document using a graphics tablet.
> 
> 
> Diffs
> -----
> 
>   ui/annotationtools.h 7107042 
>   ui/annotationtools.cpp 40fa6fe 
>   ui/pageview.h c1b36f4 
>   ui/pageview.cpp 2ef10a1 
>   ui/pageviewannotator.h a2ef90d 
>   ui/pageviewannotator.cpp 9754b5e 
> 
> Diff: http://git.reviewboard.kde.org/r/106816/diff/
> 
> 
> Testing
> -------
> 
> * The creation of annotations using the wacom pen (smooth freehand annotations)
> * The creation of annotations using the mouse (no change)
> * The operation of the annotations menu using both the mouse and the wacom pen (pen behaves just like the mouse).
> 
> 
> Thanks,
> 
> Jon Mease
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121015/616ffff9/attachment.html>