<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106816/">http://git.reviewboard.kde.org/r/106816/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Jon Mease.</div>
<p style="color: grey;"><i>Updated Oct. 15, 2012, 12:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) Cleaned up patch based on Albert's comments.
2) Reworked PageViewAnnotator::routeTabletEvent slightly. Now all tablet events over the annotations toolbar are set to ignore so that the toolbar will receive the corresponding mouse event. However, the annotation code still handles TabletMove and TabletRelease events in case an annotation has been drawn onto the toolbar itself. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds processing of QTabletEvents to the PageView class. Basically a graphics tablet will behave exactly like a mouse except while creating an annotation. When creating an annotation, the higher precision position of the QTabletEvent is used and this results in smoother free-hand annotations (See the attached image for a before and after comparison). With this patch in place it's possible to create a nice looking signature in an Okular document using a graphics tablet.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* The creation of annotations using the wacom pen (smooth freehand annotations)
* The creation of annotations using the mouse (no change)
* The operation of the annotations menu using both the mouse and the wacom pen (pen behaves just like the mouse).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ui/annotationtools.h <span style="color: grey">(7107042)</span></li>
<li>ui/annotationtools.cpp <span style="color: grey">(40fa6fe)</span></li>
<li>ui/pageview.h <span style="color: grey">(c1b36f4)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(2ef10a1)</span></li>
<li>ui/pageviewannotator.h <span style="color: grey">(a2ef90d)</span></li>
<li>ui/pageviewannotator.cpp <span style="color: grey">(9754b5e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106816/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>