[Okular-devel] Review Request: Show paper size names like "ISO/DIN A4" instead of just paper size in numbers
Thomas Fischer
fischer at unix-ag.uni-kl.de
Fri Nov 16 22:33:20 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107350/
-----------------------------------------------------------
(Updated Nov. 16, 2012, 10:33 p.m.)
Review request for Okular.
Changes
-------
Rewriting patch to use big switch to cover all paper sizes QPrinter knows. Avoids i18n for static constants.
Description
-------
This patch makes Okular not only show a document's size (width x height) in inches or millimeters, but it will try to guess the paper format's name as well.
Example: So far, for an opened PDF file in the Properties dialog (File -> Properties), it would print "Page Size: 210,016 x 297,011 mm". Using this patch, it would say instead "210,016 x 297,011 mm (portrait ISO/DIN A4)"
Diffs (updated)
-----
core/document.cpp 3e4e21a
core/document_p.h 4a20561
Diff: http://git.reviewboard.kde.org/r/107350/diff/
Testing
-------
Works for example files using format ISO/DIN A4 and legal. No example files for other formats available (e.g. Japanese JIS-B or tabloid).
Screenshots
-----------
Showing paper format "portrait ISO/DIN A4"
http://git.reviewboard.kde.org/r/107350/s/834/
Thanks,
Thomas Fischer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121116/f83c2c5e/attachment-0001.html>
More information about the Okular-devel
mailing list