[Okular-devel] Review Request: Show paper size names like "ISO/DIN A4" instead of just paper size in numbers

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107350/#review22095
-----------------------------------------------------------


To be honest i'm not a huge fan of all those data tables inside Okular, one can get the page size from Qt already, eg.

QPrinter p;
p.setPaperSize(QPrinter::A4);
qDebug() << p.paperSize(QPrinter::Inch);

What Qt does not gives us is the "visual" name for QPrinter::A4, but that can be solved with a huge switch.

Do you think you can adapt your code to query the size from QPrinter?


- Albert Astals Cid


On Nov. 16, 2012, 8:54 p.m., Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107350/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2012, 8:54 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> This patch makes Okular not only show a document's size (width x height) in inches or millimeters, but it will try to guess the paper format's name as well.
> Example: So far, for an opened PDF file in the Properties dialog (File -> Properties), it would print "Page Size: 210,016 x 297,011 mm". Using this patch, it would say instead "210,016 x 297,011 mm (portrait ISO/DIN A4)"
> 
> 
> Diffs
> -----
> 
>   core/document.cpp 3e4e21a 
>   core/document_p.h 4a20561 
> 
> Diff: http://git.reviewboard.kde.org/r/107350/diff/
> 
> 
> Testing
> -------
> 
> Works for example files using format ISO/DIN A4 and legal. No example files for other formats available (e.g. Japanese JIS-B or tabloid).
> 
> 
> Screenshots
> -----------
> 
> Showing paper format "portrait ISO/DIN A4"
>   http://git.reviewboard.kde.org/r/107350/s/834/
> 
> 
> Thanks,
> 
> Thomas Fischer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121116/a430be42/attachment-0001.html>