[Okular-devel] Review Request: Show paper size names like "ISO/DIN A4" instead of just paper size in numbers

[Thomas Fischer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107350/
-----------------------------------------------------------

(Updated Nov. 17, 2012, 11:10 a.m.)


Review request for Okular.


Changes
-------

When writing out millimeters, there is no point in showing tenth or hundredth of a mm, those digits are most likely due to rounding or conversion errors between points, inches, and millimeters. Instead, round to full millimeters.
Example: Instead of "210,016 x 297,011 mm" write "210 x 297 mm"


Description
-------

This patch makes Okular not only show a document's size (width x height) in inches or millimeters, but it will try to guess the paper format's name as well.
Example: So far, for an opened PDF file in the Properties dialog (File -> Properties), it would print "Page Size: 210,016 x 297,011 mm". Using this patch, it would say instead "210,016 x 297,011 mm (portrait ISO/DIN A4)"


Diffs (updated)
-----

  core/document.cpp 3e4e21a 
  core/document_p.h 4a20561 

Diff: http://git.reviewboard.kde.org/r/107350/diff/


Testing
-------

Works for example files using format ISO/DIN A4 and legal. No example files for other formats available (e.g. Japanese JIS-B or tabloid).


Screenshots
-----------

Showing paper format "portrait ISO/DIN A4"
  http://git.reviewboard.kde.org/r/107350/s/834/


Thanks,

Thomas Fischer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20121117/caf58142/attachment.html>