[Okular-devel] Bug 157198 - Remember position on the page in bookmark

[todd rme]

On Mon, Mar 12, 2012 at 1:52 PM, Mailson Lira <mailson at gmail.com> wrote:
> Hi everyone,
>
> Currently I'm working on this new feature[1] which is make bookmark remember
> where in the page it was saved. The solution is to make the bookmark save
> the center of the viewport, not only the page number. With that in mind, the
> user now can have as many bookmarks as he wants on a given page.
>
> This will change the behavior of the program, so I need to ask a few
> questions on how this should work.
>
> == Case 1 - "Remove bookmark" menu action ==
>
> If you right click on a *bookmarked* page (or click on Bookmark in menubar),
> you'll see an option to remove the current bookmark instead of adding a new
> one.
>
> Since the user can add another bookmark on another position we can't simply
> show the "Remove bookmark" option on a bookmarked page anymore.
>
> So what should we do with the "Remove bookmark" option?
snip
>
> Any suggestions?

I think there are two issues: identifying the bookmark, and deleting it.

1. When you put your mouse over the bookmark, the okular window
temporarily jumps to the location of the bookmark.  When your mouse
moves off, it returns to its previous location.  Would be the most
clear, but probably also has the largest performance penalty.
2. Same as 1, except that it shows a popup preview instead of moving
the view.  May have better performance, but the preview might be
harder to see due to its size.
3. When you put your mouse over the bookmark, automatically show the
bookmarks sidebar, with that bookmark visible and highlighted.
4. Always list the bookmarks in order of their position in the
document, so bookmarks in a given page will be listed (for LTR text
documents) top to bottom then left to right.  This is not mutually
exclusive with the others.

In order to remove bookmarks, I would say there are two approaches
(not mutually exclusive):

1. Have "remove bookmark" only on right-click of a bookmark in the
menu or panel.
2. Have the "remove bookmark" option visible after clicking on a
bookmark.  So you click on a bookmark in the menu or panel, it takes
you to that bookmark, and you have the option to remove the bookmark
as long as you don't move your current view (or it disappears after a
fixed amount of time).

> == Case 2 - Ctrl+B shortcut ==
>
> The Ctrl+B shortcut add or remove the page to bookmark. That may not work
> well if we have many bookmarks in the page.
> Should we detect if the current viewport is saved to bookmarks and then
> Ctrl+B will remove them? Or that shortcut will just add bookmark and the
> user needs to go to the list of saved bookmarks on the left side and remove
> it manually?
>
> The first can lead to undesirable results such as the user adding various
> bookmarks on very close (but different) positions when what he really wanted
> was to remove a bookmark.

I don't see much alternative here: ctrl-b always adds a shortcut.

> == Case 3 - Save only one bookmark per page ==
>
> The bookmark will remember the position on the page but will still allow
> only one bookmark per page. That will not change the behavior of okular but
> IMHO doesn't make much sense.

This is no good, especially for documents with long or very dense
pages.  I think it defeats the purpose of remembering you location on
the page.

-Todd