[Nepomuk] Review Request 109398: Added support to multiple artist and genre frames in MP3, Ogg and FLAC audio files.

[Ignacio Serantes]

> On March 11, 2013, 8:06 p.m., Vishesh Handa wrote:
> > This is probably a stupid question, but doesn't tags->artist() find the these artists? Same question for tags->genres().

Sadly not so this stuff is required. You could test it for your own adding to artist to an audio file using KID3 and then indexing it. Only one of the artist is added. The same with genres.

More information here: http://taglib.github.com/api/classTagLib_1_1ID3v2_1_1Tag.html#a5094b04654b0912db9dca61de11f4663


- Ignacio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109398/#review29015
-----------------------------------------------------------


On March 10, 2013, 11:46 p.m., Ignacio Serantes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109398/
> -----------------------------------------------------------
> 
> (Updated March 10, 2013, 11:46 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Some frames could be duplicated in ID3v2 and Ogg specification so I added support to duplicate artist and genre frames in MP3, Ogg and FLAC audio files.
> 
> As I'm not a C/C++ this code could be a totally mess and for sure could be optimized :).
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexer/taglibextractor.cpp a5a5ed6 
> 
> Diff: http://git.reviewboard.kde.org/r/109398/diff/
> 
> 
> Testing
> -------
> 
> Tested with my music database and seems to work properly.
> 
> 
> Thanks,
> 
> Ignacio Serantes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130311/a0478fa5/attachment.html>