[Nepomuk] Review Request 109398: Added support to multiple artist and genre frames in MP3, Ogg and FLAC audio files.

[Ignacio Serantes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109398/
-----------------------------------------------------------

(Updated March 12, 2013, 6:41 p.m.)


Review request for Nepomuk and Vishesh Handa.


Changes
-------

I made all required changes.


Description
-------

Some frames could be duplicated in ID3v2 and Ogg specification so I added support to duplicate artist and genre frames in MP3, Ogg and FLAC audio files.

As I'm not a C/C++ this code could be a totally mess and for sure could be optimized :).


Diffs (updated)
-----

  services/fileindexer/indexer/taglibextractor.cpp a5a5ed6 

Diff: http://git.reviewboard.kde.org/r/109398/diff/


Testing
-------

Tested with my music database and seems to work properly.


Thanks,

Ignacio Serantes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130312/6a6414dd/attachment-0001.html>