[Nepomuk] Review Request 109398: Added support to multiple artist and genre frames in MP3, Ogg and FLAC audio files.
Vishesh Handa
me at vhanda.in
Mon Mar 11 19:06:34 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109398/#review29015
-----------------------------------------------------------
This is probably a stupid question, but doesn't tags->artist() find the these artists? Same question for tags->genres().
services/fileindexer/indexer/taglibextractor.cpp
<http://git.reviewboard.kde.org/r/109398/#comment21710>
Could you please use find instead of iterating over all the fields?
services/fileindexer/indexer/taglibextractor.cpp
<http://git.reviewboard.kde.org/r/109398/#comment21711>
Ditto!
services/fileindexer/indexer/taglibextractor.cpp
<http://git.reviewboard.kde.org/r/109398/#comment21709>
Please make sure you remove the extra space before committing.
- Vishesh Handa
On March 10, 2013, 10:46 p.m., Ignacio Serantes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109398/
> -----------------------------------------------------------
>
> (Updated March 10, 2013, 10:46 p.m.)
>
>
> Review request for Nepomuk and Vishesh Handa.
>
>
> Description
> -------
>
> Some frames could be duplicated in ID3v2 and Ogg specification so I added support to duplicate artist and genre frames in MP3, Ogg and FLAC audio files.
>
> As I'm not a C/C++ this code could be a totally mess and for sure could be optimized :).
>
>
> Diffs
> -----
>
> services/fileindexer/indexer/taglibextractor.cpp a5a5ed6
>
> Diff: http://git.reviewboard.kde.org/r/109398/diff/
>
>
> Testing
> -------
>
> Tested with my music database and seems to work properly.
>
>
> Thanks,
>
> Ignacio Serantes
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130311/c37d8614/attachment-0001.html>
More information about the Nepomuk
mailing list