[Nepomuk] Review Request: Misc Filewatch fixes
Simeon Bird
bladud at gmail.com
Sat Oct 27 18:29:24 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107082/
-----------------------------------------------------------
Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
Description
-------
Some fairly trivial misc improvements to the filewatch service. Probably don't make a big difference, but probably a good idea.
- Use QReadWriteLock instead of QMutex in FileIndexerConfig, thus allowing multiple threads to call shouldFolderBeIndexed at once (not that we really do that right now).
- Add the IN_EXCL_UNLINK inotify flag. On recent (2.6.36) kernels, this means we don't generate events for files once
they have been unlinked from the directory we are watching. Prevents waking up for some already-deleted temporary files.
Diffs
-----
services/fileindexer/fileindexerconfig.h 7debaf3
services/fileindexer/fileindexerconfig.cpp 5226a79
services/filewatch/kinotify.h 6e3f1c0
services/filewatch/kinotify.cpp 9868b90
Diff: http://git.reviewboard.kde.org/r/107082/diff/
Testing
-------
Compiled, ran for a bit, didn't seem to break anything.
Thanks,
Simeon Bird
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121027/2be701fc/attachment.html>
More information about the Nepomuk
mailing list