[Nepomuk] Review Request: Misc Filewatch fixes
David Faure
faure at kde.org
Mon Oct 29 11:18:46 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107082/#review21082
-----------------------------------------------------------
This assumes that QRegExp::exactMatch is re-entrant, i.e. that it doesn't update an internal cache on demand. I'm not so sure of that, the regexp parsing sounds like a very good candidate for on-demand parsing, unless you make extra sure that it's all done upfront.
- David Faure
On Oct. 27, 2012, 6:29 p.m., Simeon Bird wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107082/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2012, 6:29 p.m.)
>
>
> Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
>
>
> Description
> -------
>
> Some fairly trivial misc improvements to the filewatch service. Probably don't make a big difference, but probably a good idea.
>
> - Use QReadWriteLock instead of QMutex in FileIndexerConfig, thus allowing multiple threads to call shouldFolderBeIndexed at once (not that we really do that right now).
>
> - Add the IN_EXCL_UNLINK inotify flag. On recent (2.6.36) kernels, this means we don't generate events for files once
> they have been unlinked from the directory we are watching. Prevents waking up for some already-deleted temporary files.
>
>
> Diffs
> -----
>
> services/fileindexer/fileindexerconfig.h 7debaf3
> services/fileindexer/fileindexerconfig.cpp 5226a79
> services/filewatch/kinotify.h 6e3f1c0
> services/filewatch/kinotify.cpp 9868b90
>
> Diff: http://git.reviewboard.kde.org/r/107082/diff/
>
>
> Testing
> -------
>
> Compiled, ran for a bit, didn't seem to break anything.
>
>
> Thanks,
>
> Simeon Bird
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121029/0da270c9/attachment.html>
More information about the Nepomuk
mailing list