[Nepomuk] Review Request: Watch fixes for symlinks and fiters

[Simeon Bird]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107080/
-----------------------------------------------------------

(Updated Oct. 27, 2012, 9:39 p.m.)


Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.


Description
-------

Some fixes for filtering, and some symlink handling (this is patch 2).

1. Do not watch symlinks when their target is already watched (by being in the hash of watched paths).

This does not stop all double-watching of symlinks,
because the watch on the symlink may be installed before
the watch on the target.

However, it prevents infinite recursion if someone has done this:

mkdir ~/test
cd test
ln -s ../ test

which is nice. 

2. Do not re-index symlinks to folders that are already indexed under
another name. This just saves some CPU cycles and double-counting of results in dolphin search.

3. Do not watch folders in the filter exclude list. By
 default this affects only CMakeFiles and auto4mte (as agreed with Vishesh earlier)

4. Do not override addWatch in IgnoringKInotify. This was intended to avoid watching folders on
the exclude list, but did not really work, and is implemented better by 3. 


This addresses bug 306342.
    http://bugs.kde.org/show_bug.cgi?id=306342


Diffs
-----

  services/fileindexer/fileindexerconfig.cpp 5226a79 
  services/filewatch/nepomukfilewatch.cpp dbe2f82 

Diff: http://git.reviewboard.kde.org/r/107080/diff/


Testing
-------

Compiled, checked that the cases listed are watched or not watched correctly. 


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121027/df028587/attachment.html>