[Nepomuk] Nepomuk Tags kioslave - Please Review

[Vishesh Handa]

I chatted with David, and I've enabled 'renameFromFile' and 'copyFromFile'.
And I give an error if one tries to rename a local url in the tags
kioslave. This results in those cut (from file) + paste (to tags) failing,
and the file is not lost.

Ideally, this should have been seemly converted to a copy operation. We
still need to figure out a way to do that.

On Thu, Nov 29, 2012 at 5:17 PM, Vishesh Handa <me at vhanda.in> wrote:

>
>
>
> On Fri, Nov 23, 2012 at 12:57 AM, Albert Astals Cid <aacid at kde.org> wrote:
>
>> El Dijous, 22 de novembre de 2012, a les 10:27:41, David Faure va
>> escriure:
>> > On Thursday 22 November 2012 00:24:12 Albert Astals Cid wrote:
>> > > El Dimecres, 21 de novembre de 2012, a les 16:15:01, David Faure va
>> >
>> > escriure:
>> > > > On Wednesday 07 November 2012 02:27:17 Albert Astals Cid wrote:
>> > > > > Ahh, you mean copying from file: to tags:
>> > > > Moving from file: to tags:, rather.
>> > >
>> > > Right
>> > >
>> > > > > I see... I'd like to hear David's opinion on how that is going to
>> be
>> > > > > fixed
>> > > > > at  the kio/kioslave level.
>> > > >
>> > > > Not at that level. Apps should be able to call move and end up with
>> a
>> > > > move.
>> > >
>> > > Even if that means destroying the file into hyperspace?
>> >
>> > Well, kioslaves were meant to be V*FS*. A file system doesn't lose files
>> > into hyperspace :)
>>
>> Sure, but it's still Virtual ;-)
>>
>> > However we already have a number of settings for "this or that
>> functionality
>> > isn't supported by this kioslave". Hmm, I wonder, what does tags:/ do in
>> > put()? Where does it "write the file", if it's only a virtual
>> collection of
>> > stuff?
>>
>> Not sure, but i understand it adds the tag of the url you are in to the
>> file
>> you are dropping.
>>
>>
>> >
>> > If put() isn't supported, then moving (by get+put) won't be supported.
>> > Only copyFromFile would be possible, which is exactly what you need,
>> isn't
>> > it?
>>
>> Ah, interesting, maybe copyFromFile is what Vishesh needs? Vishesh does it
>> make sense dropping urls to tags:/ from something different than file:/ ?
>>
>
> No. It doesn't.
>
> Theoretically one can tag anything but for now I only want to support
> files.
>
>
>> Cheers,
>>   Albert
>>
>> >
>> > In other words, try not implementing put, if that makes sense, and let
>> me
>> > know what doesn't work.
>> >
>> > > > But the fix is to let drag-n-drop trigger a copy rather than
>> allowing
>> > > > the
>> > > > user to select "move". The quick fix for that is
>> > > > http://www.davidfaure.fr/2012/konq_operations.cpp.diff
>> > > > Which hardcodes the protocol name, but at least it gets the job
>> done.
>> > > >
>> > > > If we agree about this on principle, then the next step to make it
>> > > > generic
>> > > > could be to add another field in .protocol files, say
>> > > > forceDropAction=(copy|move)
>> > > > The fact that kio_trash needs forceDropAction=move shows that this
>> might
>> > > > make sense, we already have two users for this setting.
>> > >
>> > > I guess that works for me, since apps won't probably ever call "move"
>> into
>> > > a tags: url
>> >
>> > OK. But let's keep this solution under the arm for now, until we find
>> out
>> > about put() above.
>> >
>> > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
>> unsubscribe
>> > >> <<
>>
>> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
>> unsubscribe <<
>>
>
>
>
> --
> Vishesh Handa
>
>


-- 
Vishesh Handa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121129/1ba09e4a/attachment.html>