[Nepomuk] Review Request: FileWatch: Do not always add inotify watches for removable media

Vishesh Handa me at vhanda.in
Mon Dec 31 09:41:46 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108047/
-----------------------------------------------------------

Review request for Nepomuk.


Description
-------

    FileWatch: Do not always add inotify watches for removable media
    
    Not everyone wants watches to be added to the removable media. They are
    okay with loosing tags/ratings and in removable media. Also, certain
    users do not watch watches ever added for Network Shares - It results in
    a large amount of network load which is not required.
    
    The following options can disable watches in nepomukstrigirc -
    
    [RemovableMedia]
    add watches=true
    add watches network share=false
    
    By default watches are never added to network shares, and they are
    always added for removable media.
    
    BUG: 308474


This addresses bug 308474.
    http://bugs.kde.org/show_bug.cgi?id=308474


Diffs
-----

  services/filewatch/nepomukfilewatch.cpp e809bcf 

Diff: http://git.reviewboard.kde.org/r/108047/diff/


Testing
-------

Not really. I don't have any network shares. I will test it out with a pen-drive later.


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121231/38c180fa/attachment.html>


More information about the Nepomuk mailing list