[Nepomuk] Review Request: FileWatch: Do not always add inotify watches for removable media

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108047/#review24310
-----------------------------------------------------------

Ship it!


Only some notpicking below...


services/filewatch/nepomukfilewatch.cpp
<http://git.reviewboard.kde.org/r/108047/#comment18654>

    Nitpick: no need to introduce this variable.



services/filewatch/nepomukfilewatch.cpp
<http://git.reviewboard.kde.org/r/108047/#comment18655>

    Again the code would imho more readable without the additional variable and a single if clause.



services/filewatch/nepomukfilewatch.cpp
<http://git.reviewboard.kde.org/r/108047/#comment18656>

    This sounds like a good idea. On that note it would be powerful to be able to watch all file resources under a specific parent path using the ResourceWatcher...


- Sebastian Trueg


On Dec. 31, 2012, 9:41 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108047/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2012, 9:41 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
>     FileWatch: Do not always add inotify watches for removable media
>     
>     Not everyone wants watches to be added to the removable media. They are
>     okay with loosing tags/ratings and in removable media. Also, certain
>     users do not watch watches ever added for Network Shares - It results in
>     a large amount of network load which is not required.
>     
>     The following options can disable watches in nepomukstrigirc -
>     
>     [RemovableMedia]
>     add watches=true
>     add watches network share=false
>     
>     By default watches are never added to network shares, and they are
>     always added for removable media.
>     
>     BUG: 308474
> 
> 
> This addresses bug 308474.
>     http://bugs.kde.org/show_bug.cgi?id=308474
> 
> 
> Diffs
> -----
> 
>   services/filewatch/nepomukfilewatch.cpp e809bcf 
> 
> Diff: http://git.reviewboard.kde.org/r/108047/diff/
> 
> 
> Testing
> -------
> 
> Not really. I don't have any network shares. I will test it out with a pen-drive later.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121231/f0572bfa/attachment.html>