[Nepomuk] Review Request: FileWatch: Do not add watches for system links
Vishesh Handa
me at vhanda.in
Mon Dec 31 09:49:53 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108025/
-----------------------------------------------------------
(Updated Dec. 31, 2012, 9:49 a.m.)
Review request for Nepomuk and Simeon Bird.
Changes
-------
Forgot one place. We should never follow system links.
Description
-------
Following system links can lead to various infinite cycles, which is
something we do not ever want.
I'm not sure if there is any advantage gained by adding watches to them?
Diffs (updated)
-----
services/filewatch/kinotify.cpp 747b67c
services/filewatch/nepomukfilewatch.cpp e809bcf
Diff: http://git.reviewboard.kde.org/r/108025/diff/
Testing
-------
Thanks,
Vishesh Handa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121231/47c28478/attachment.html>
More information about the Nepomuk
mailing list