[Nepomuk] Review Request: Add button to force the file indexer update all folders

[Gabriel Poesia]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107553/
-----------------------------------------------------------

(Updated Dec. 2, 2012, 6:34 p.m.)


Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.


Changes
-------

Thank you, Kai Uwe Broulik! I wasn't aware of the usability standards. 
I removed the whitespace changes and renamed the method. updateAllFolders really makes more sense - it's what the button does, not its text.

But what would be a better place to put the button? Maybe in the "Advanced Settings" tab in KCM? The problem is it's not exactly a "setting", but the tab could also be renamed (to just "Advanced", for example) so it fits.


Description
-------

Add a button to the KCM Nepomuk as suggested in bug #303658. When clicked, the indexer executes the updateAllFolders() method.
The widget was placed in the Nepomuk Repository Details dialog, along with the "Suspend/Resume File Indexing". I'm not sure if it violates
any design principles behind KDE, KCM or Nepomuk (if it should have an icon, for example, like the two other buttons in the dialog).


This addresses bug 303658.
    http://bugs.kde.org/show_bug.cgi?id=303658


Diffs (updated)
-----

  nepomuk/kcm/statuswidget.h 088799e 
  nepomuk/kcm/statuswidget.cpp 36e66f5 
  nepomuk/kcm/statuswidget.ui 46e4d26 

Diff: http://git.reviewboard.kde.org/r/107553/diff/


Testing
-------

Compiled, installed, ran kcmshell4 nepomuk. The file indexer was idle. 
Clicking the button changed the status message to "Scanning for recent changes in [...]".


Thanks,

Gabriel Poesia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121202/086bebf2/attachment.html>