<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107553/">http://git.reviewboard.kde.org/r/107553/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.</div>
<div>By Gabriel Poesia.</div>
<p style="color: grey;"><i>Updated Dec. 2, 2012, 6:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you, Kai Uwe Broulik! I wasn't aware of the usability standards.
I removed the whitespace changes and renamed the method. updateAllFolders really makes more sense - it's what the button does, not its text.
But what would be a better place to put the button? Maybe in the "Advanced Settings" tab in KCM? The problem is it's not exactly a "setting", but the tab could also be renamed (to just "Advanced", for example) so it fits.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a button to the KCM Nepomuk as suggested in bug #303658. When clicked, the indexer executes the updateAllFolders() method.
The widget was placed in the Nepomuk Repository Details dialog, along with the "Suspend/Resume File Indexing". I'm not sure if it violates
any design principles behind KDE, KCM or Nepomuk (if it should have an icon, for example, like the two other buttons in the dialog).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled, installed, ran kcmshell4 nepomuk. The file indexer was idle.
Clicking the button changed the status message to "Scanning for recent changes in [...]".</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=303658">303658</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/kcm/statuswidget.h <span style="color: grey">(088799e)</span></li>
<li>nepomuk/kcm/statuswidget.cpp <span style="color: grey">(36e66f5)</span></li>
<li>nepomuk/kcm/statuswidget.ui <span style="color: grey">(46e4d26)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107553/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>