[Nepomuk] Review Request: Add button to force the file indexer update all folders

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107553/#review22911
-----------------------------------------------------------


Imho if that button is present, it should not be in such a prominent position like the repository details dialog which you can trigger by clicking the Nepomuk tray icon. Users shouldn't have the need to click that button.


nepomuk/kcm/statuswidget.h
<http://git.reviewboard.kde.org/r/107553/#comment17478>

    Maybe use slotUpdateAllFolders to match with the indexerservice call?



nepomuk/kcm/statuswidget.cpp
<http://git.reviewboard.kde.org/r/107553/#comment17480>

    Whitespace



nepomuk/kcm/statuswidget.cpp
<http://git.reviewboard.kde.org/r/107553/#comment17479>

    Whitespace



nepomuk/kcm/statuswidget.ui
<http://git.reviewboard.kde.org/r/107553/#comment17477>

    Use title capitalization here since it is a button (see http://techbase.kde.org/Projects/Usability/HIG/Capitalization)


- Kai Uwe Broulik


On Dec. 2, 2012, 2:13 a.m., Gabriel Poesia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107553/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2012, 2:13 a.m.)
> 
> 
> Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> Add a button to the KCM Nepomuk as suggested in bug #303658. When clicked, the indexer executes the updateAllFolders() method.
> The widget was placed in the Nepomuk Repository Details dialog, along with the "Suspend/Resume File Indexing". I'm not sure if it violates
> any design principles behind KDE, KCM or Nepomuk (if it should have an icon, for example, like the two other buttons in the dialog).
> 
> 
> This addresses bug 303658.
>     http://bugs.kde.org/show_bug.cgi?id=303658
> 
> 
> Diffs
> -----
> 
>   nepomuk/kcm/statuswidget.h 088799e 
>   nepomuk/kcm/statuswidget.cpp 36e66f5 
>   nepomuk/kcm/statuswidget.ui 46e4d26 
> 
> Diff: http://git.reviewboard.kde.org/r/107553/diff/
> 
> 
> Testing
> -------
> 
> Compiled, installed, ran kcmshell4 nepomuk. The file indexer was idle. 
> Clicking the button changed the status message to "Scanning for recent changes in [...]".
> 
> 
> Thanks,
> 
> Gabriel Poesia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121202/23971f93/attachment.html>