[Nepomuk] Review Request: ErrorCache: Use QThreadStorage instead of a QHash with a mutex

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105812/#review16758
-----------------------------------------------------------

Ship it!


Very good. Please push to 2.8 also.

- Sebastian Trueg


On Aug. 1, 2012, 11:50 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105812/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 11:50 a.m.)
> 
> 
> Review request for Nepomuk, Soprano and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     ErrorCache: Use QThreadStorage instead of a QHash with a mutex
>     
>     We avoid allocating a HashTable since with QThreadStorage, the data is
>     stored in the corresponding thread class.
>     
>     Additionally, with this approach the data is actually deleted when a
>     thread is deleted, instead of just lying there for the entire execution
>     of the program.
> 
> 
> Diffs
> -----
> 
>   soprano/error.cpp bff34dd 
> 
> Diff: http://git.reviewboard.kde.org/r/105812/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120801/5968c587/attachment.html>