[Nepomuk] Review Request: ErrorCache: Use QThreadStorage instead of a QHash with a mutex

Vishesh Handa me at vhanda.in
Wed Aug 1 11:50:43 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105812/
-----------------------------------------------------------

Review request for Nepomuk, Soprano and Sebastian Trueg.


Description
-------

    ErrorCache: Use QThreadStorage instead of a QHash with a mutex
    
    We avoid allocating a HashTable since with QThreadStorage, the data is
    stored in the corresponding thread class.
    
    Additionally, with this approach the data is actually deleted when a
    thread is deleted, instead of just lying there for the entire execution
    of the program.


Diffs
-----

  soprano/error.cpp bff34dd 

Diff: http://git.reviewboard.kde.org/r/105812/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120801/b5cc841e/attachment.html>


More information about the Nepomuk mailing list