[Nepomuk] Review Request: ErrorCache: Use QThreadStorage instead of a QHash with a mutex
Commit Hook
null at kde.org
Wed Aug 1 12:12:55 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105812/#review16759
-----------------------------------------------------------
This review has been submitted with commit f4d2b9898ff958db1c69ac55fb21677bb6075e24 by Vishesh Handa to branch 2.8.
- Commit Hook
On Aug. 1, 2012, 11:50 a.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105812/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2012, 11:50 a.m.)
>
>
> Review request for Nepomuk, Soprano and Sebastian Trueg.
>
>
> Description
> -------
>
> ErrorCache: Use QThreadStorage instead of a QHash with a mutex
>
> We avoid allocating a HashTable since with QThreadStorage, the data is
> stored in the corresponding thread class.
>
> Additionally, with this approach the data is actually deleted when a
> thread is deleted, instead of just lying there for the entire execution
> of the program.
>
>
> Diffs
> -----
>
> soprano/error.cpp bff34dd
>
> Diff: http://git.reviewboard.kde.org/r/105812/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120801/533389aa/attachment.html>
More information about the Nepomuk
mailing list