[Nepomuk] Re: Review Request: Changes to nepomuk-simpleresource-rcgen

[Artem Serebriyskiy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101964/
-----------------------------------------------------------

(Updated July 18, 2011, 9:30 p.m.)


Review request for Nepomuk.


Changes
-------

Well, I put it in separate folder because I think that repo should have some order. Nobody will search for script in lib subfolder. 
But I agree that this way diff is unreadable. I am posting a new diff, that includes only changes, without file moving


Summary
-------

1. Swtich to argparse
2. changes in script header
3. move to folder rcgen
4. Option --list-headers, wich will output generated headers. It implies --quiet


Diffs (updated)
-----

  nepomuk/services/storage/CMakeLists.txt c6e170f 
  nepomuk/services/storage/rcgen/CMakeLists.txt PRE-CREATION 
  nepomuk/services/storage/rcgen/nepomuk-simpleresource-rcgen.py 304db56 

Diff: http://git.reviewboard.kde.org/r/101964/diff


Testing
-------

My system, used in Nepomuk Web Extractor


Thanks,

Artem

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110718/998fa2a8/attachment.htm