[Nepomuk] Re: Review Request: Changes to nepomuk-simpleresource-rcgen

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101964/#review4840
-----------------------------------------------------------



nepomuk/services/storage/rcgen/nepomuk-simpleresource-rcgen.py
<http://git.reviewboard.kde.org/r/101964/#comment4203>

    I don't understand this part. Two prefixes?



nepomuk/services/storage/rcgen/nepomuk-simpleresource-rcgen.py
<http://git.reviewboard.kde.org/r/101964/#comment4204>

    This method is never used.



nepomuk/services/storage/rcgen/nepomuk-simpleresource-rcgen.py
<http://git.reviewboard.kde.org/r/101964/#comment4205>

    Why do we need the list_headers? Is it to install the generated code? I would actually prefer that these headers are never installed. Contrary to the old rcgen there is no code that could be compiled in any lib and then be shared. Thus, there is no advantage in installing the files, only the disadvantage of unused installed files.



nepomuk/services/storage/rcgen/nepomuk-simpleresource-rcgen.py
<http://git.reviewboard.kde.org/r/101964/#comment4206>

    visibility_macro?



nepomuk/services/storage/rcgen/nepomuk-simpleresource-rcgen.py
<http://git.reviewboard.kde.org/r/101964/#comment4207>

    visibility_macro?



nepomuk/services/storage/rcgen/nepomuk-simpleresource-rcgen.py
<http://git.reviewboard.kde.org/r/101964/#comment4208>

    There is no point in visibility settings with a header-only project.



nepomuk/services/storage/rcgen/nepomuk-simpleresource-rcgen.py
<http://git.reviewboard.kde.org/r/101964/#comment4209>

    I do not like this. Commented code is ugly. If you want to keep the code, please do so in a branch.


- Sebastian


On July 18, 2011, 9:30 p.m., Artem Serebriyskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101964/
> -----------------------------------------------------------
> 
> (Updated July 18, 2011, 9:30 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> 1. Swtich to argparse
> 2. changes in script header
> 3. move to folder rcgen
> 4. Option --list-headers, wich will output generated headers. It implies --quiet
> 
> 
> Diffs
> -----
> 
>   nepomuk/services/storage/CMakeLists.txt c6e170f 
>   nepomuk/services/storage/rcgen/CMakeLists.txt PRE-CREATION 
>   nepomuk/services/storage/rcgen/nepomuk-simpleresource-rcgen.py 304db56 
> 
> Diff: http://git.reviewboard.kde.org/r/101964/diff
> 
> 
> Testing
> -------
> 
> My system, used in Nepomuk Web Extractor
> 
> 
> Thanks,
> 
> Artem
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110719/a3463a77/attachment-0001.htm