[Nepomuk] Re: Review Request: Changes to nepomuk-simpleresource-rcgen

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101964/#review4808
-----------------------------------------------------------


It is quite hard to review this since there is no diff but only a removed and a newly added file. Why don't you just leave the script in the lib dir? After all creating a folder for a single file seems a bit much.

- Sebastian


On July 16, 2011, 10:56 a.m., Artem Serebriyskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101964/
> -----------------------------------------------------------
> 
> (Updated July 16, 2011, 10:56 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> 1. Swtich to argparse
> 2. changes in script header
> 3. move to folder rcgen
> 4. Option --list-headers, wich will output generated headers. It implies --quiet
> 
> 
> Diffs
> -----
> 
>   nepomuk/services/storage/CMakeLists.txt c6e170f 
>   nepomuk/services/storage/lib/CMakeLists.txt 44a49a5 
>   nepomuk/services/storage/lib/nepomuk-simpleresource-rcgen.py 304db56 
>   nepomuk/services/storage/rcgen/CMakeLists.txt PRE-CREATION 
>   nepomuk/services/storage/rcgen/nepomuk-simpleresource-rcgen.py PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101964/diff
> 
> 
> Testing
> -------
> 
> My system, used in Nepomuk Web Extractor
> 
> 
> Thanks,
> 
> Artem
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110718/454a573f/attachment.htm