[Nepomuk] Re: Review Request: Handle 0 manager parameter in Nepomuk::Resource

[Sebastian Trueg]

> On April 6, 2011, 4:52 p.m., Vishesh Handa wrote:
> > Can we change the default argument for Nepomuk::File( const KUrl& url = KUrl(), ResourceManager* manager = 0 ) from 0 to ResourceManager::instance() without breaking binary compatibility? If we can then we should do that as well.
> > 
> > Otherwise it's fine. Nepomuk::Resource obviously shouldn't ever crash.
> >

AFAIK it is indeed BC since the lib is not changed at all. But taking this risk, however minimal, is not really necessary as my patch does the same thing internally, even better, it catches bad usage like: "File myCrashyFile(myUrl, 0)"


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101039/#review2445
-----------------------------------------------------------


On April 6, 2011, 4:04 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101039/
> -----------------------------------------------------------
> 
> (Updated April 6, 2011, 4:04 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> Allow 0 manager parameter without crashing. This is a small fix but I want to start doing more things in the open. :)
> 
> 
> Diffs
> -----
> 
>   nepomuk/core/resource.cpp f2134af 
> 
> Diff: http://git.reviewboard.kde.org/r/101039/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110407/c0f99204/attachment.htm