[Nepomuk] Re: Review Request: Handle 0 manager parameter in Nepomuk::Resource

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101039/#review2445
-----------------------------------------------------------

Ship it!


Can we change the default argument for Nepomuk::File( const KUrl& url = KUrl(), ResourceManager* manager = 0 ) from 0 to ResourceManager::instance() without breaking binary compatibility? If we can then we should do that as well.

Otherwise it's fine. Nepomuk::Resource obviously shouldn't ever crash.


- Vishesh


On April 6, 2011, 4:04 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101039/
> -----------------------------------------------------------
> 
> (Updated April 6, 2011, 4:04 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> Allow 0 manager parameter without crashing. This is a small fix but I want to start doing more things in the open. :)
> 
> 
> Diffs
> -----
> 
>   nepomuk/core/resource.cpp f2134af 
> 
> Diff: http://git.reviewboard.kde.org/r/101039/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110406/b31a7196/attachment-0001.htm