[Nepomuk] Re: Review Request: Handle 0 manager parameter in Nepomuk::Resource

[Matthias Fuchs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101039/#review2441
-----------------------------------------------------------


Looks nice to me. Though personally I believe that the initial issue is rather Nepomuk::File, acting as if a zero ptr was ok, while the Nepomuk::Resource constructor declaration clearly suggest otherwise.

So maybe more clean would be to fix it in Nepomuk::File with something like (if that works):

Nepomuk::File::File( const KUrl& url, ResourceManager* manager )
    : Resource( url, Nepomuk::Vocabulary::NFO::FileDataObject(), (manager ? manager : ResourceManager::instance() ) )

- Matthias


On April 6, 2011, 4:04 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101039/
> -----------------------------------------------------------
> 
> (Updated April 6, 2011, 4:04 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> Allow 0 manager parameter without crashing. This is a small fix but I want to start doing more things in the open. :)
> 
> 
> Diffs
> -----
> 
>   nepomuk/core/resource.cpp f2134af 
> 
> Diff: http://git.reviewboard.kde.org/r/101039/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110406/054038c5/attachment.htm