<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101039/">http://git.reviewboard.kde.org/r/101039/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks nice to me. Though personally I believe that the initial issue is rather Nepomuk::File, acting as if a zero ptr was ok, while the Nepomuk::Resource constructor declaration clearly suggest otherwise.
So maybe more clean would be to fix it in Nepomuk::File with something like (if that works):
Nepomuk::File::File( const KUrl& url, ResourceManager* manager )
: Resource( url, Nepomuk::Vocabulary::NFO::FileDataObject(), (manager ? manager : ResourceManager::instance() ) )</pre>
<br />
<p>- Matthias</p>
<br />
<p>On April 6th, 2011, 4:04 p.m., Sebastian Trueg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk.</div>
<div>By Sebastian Trueg.</div>
<p style="color: grey;"><i>Updated April 6, 2011, 4:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Allow 0 manager parameter without crashing. This is a small fix but I want to start doing more things in the open. :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/core/resource.cpp <span style="color: grey">(f2134af)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101039/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>