[Nepomuk] Strigi Feeder

[Vishesh Handa]

Sorry. Last iteration.

I understood what you meant by adding them directly to ResourceHash. I
wonder why I didn't think of that!

Anyway. I'm committing this new version. Unless you have some objections?

- Vishesh Handa

On Wed, Jul 14, 2010 at 5:23 PM, Sebastian Trüg <trueg at kde.org> wrote:

> On 07/14/2010 01:30 PM, Vishesh Handa wrote:
> >         8. You did it again: a static method named "toSparql". Please do
> >         not do
> >         that. :)
> >
> >
> >     But this time I added documentation as to what kind of query it
> >     creates. I understand that these kind of function names are bad, but
> >     I can't think of any alternative. Could you please suggest some name?
>
> well, you could always put the method in ResourceStruct and then keep
> the name. Or you call it resourceStructToSparql or buildResourceQuery
>
> >         As you can see I have no "real" comments since IMHO you did a
> >         great job.
> >         So please go ahead and commit that (maybe with some changes
> >         based on my
> >         comments) to trunk. Then testing can commence. :)
> >
> >
> >     Are you sure? Just say "Yes' and I'll commit it.
>
> yes
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20100714/4625e107/attachment-0001.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nepomukindexfeeder_2.diff
Type: text/x-patch
Size: 27142 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/nepomuk/attachments/20100714/4625e107/attachment-0001.diff