Sorry. Last iteration. <br><br>I understood what you meant by adding them directly to ResourceHash. I wonder why I didn't think of that! <br><br>Anyway. I'm committing this new version. Unless you have some objections?<br>
<br>- Vishesh Handa<br><br><div class="gmail_quote">On Wed, Jul 14, 2010 at 5:23 PM, Sebastian Trüg <span dir="ltr"><<a href="mailto:trueg@kde.org">trueg@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">On 07/14/2010 01:30 PM, Vishesh Handa wrote:<br>
> 8. You did it again: a static method named "toSparql". Please do<br>
> not do<br>
> that. :)<br>
><br>
><br>
> But this time I added documentation as to what kind of query it<br>
> creates. I understand that these kind of function names are bad, but<br>
> I can't think of any alternative. Could you please suggest some name?<br>
<br>
</div>well, you could always put the method in ResourceStruct and then keep<br>
the name. Or you call it resourceStructToSparql or buildResourceQuery<br>
<div class="im"><br>
> As you can see I have no "real" comments since IMHO you did a<br>
> great job.<br>
> So please go ahead and commit that (maybe with some changes<br>
> based on my<br>
> comments) to trunk. Then testing can commence. :)<br>
><br>
><br>
> Are you sure? Just say "Yes' and I'll commit it.<br>
<br>
</div>yes<br>
</blockquote></div><br>